Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Overhaul config using Pydantic #297

Closed
wants to merge 4 commits into from

Conversation

mrkaye97
Copy link
Contributor

Copy of #296

Overhauling the client config to use Pydantic to get rid of a lot of convoluted parsing + validation code.

Main things here:

  • Got rid of the config.yaml stuff since nobody seems to be using that and it makes the code paths significantly more complicated.
  • Strict typing for all of the fields with the same defaults + field validators in the cases where there's parsing logic like extracting something from the JWT
  • Got rid of the ConfigLoader, since now we can instantiate the class directly
  • Enabled mypy for the new config class now that types check out

@mrkaye97 mrkaye97 closed this Jan 13, 2025
@mrkaye97 mrkaye97 deleted the feat--config-overhaul branch January 13, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant