Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix soundtrack on pages #32

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Conversation

haszari
Copy link
Owner

@haszari haszari commented Dec 6, 2020

The soundtrack was not working on page content type.

There were two issues:

  • The custom meta field (for page tempo) was only registered for (blog) post content type.
  • The new code to limit to non-archive pages was limiting to single blog post only.

This PR fixes both of those so soundtrack can be used on any "single" page for any post type, typically posts and pages.

- register tempo custom meta field for all post types
- fix logic in content filter so tempo is rendered any post type single page
@haszari haszari merged commit da41680 into master Dec 6, 2020
@haszari haszari deleted the fix/page-soundtrack-broken-on-page-type branch December 6, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant