Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option for relaxed or canonical extended json output #84

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

hallettj
Copy link
Collaborator

@hallettj hallettj commented Jul 2, 2024

Adds an option to allow users to opt into "relaxed" mode for Extended JSON output. Keeps "canonical" mode as the default because it is lossless. For example relaxed mode does not preserve the exact numeric type of each numeric value, while canonical mode does.

This does not affect inputs. For example sorts and filters will accept either canonical or relaxed input modes as before.

MDB-169

@hallettj hallettj requested review from codedmart and dmoverton July 2, 2024 20:27
@hallettj hallettj self-assigned this Jul 2, 2024
Copy link
Collaborator

@codedmart codedmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we go with relaxed be default?

@hallettj
Copy link
Collaborator Author

hallettj commented Jul 8, 2024

Did we go with relaxed be default?

Per discussion from the meeting, we're sticking with strict by default to prioritize avoiding any potential data loss

@hallettj hallettj merged commit 4bb84aa into main Jul 8, 2024
1 check passed
@hallettj hallettj deleted the jesse/canonical-vs-relaxed-config-option branch July 8, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants