Add "sensible" default behaviour for the CLI update command
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sampling with default sample size of 10
dmoverton
commented
Mar 27, 2024
| Some(schema_bson) => { | ||
| let validator_schema = | ||
| from_bson::<ValidatorSchema>(schema_bson.clone()).map_err(|err| { | ||
| MongoAgentError::BadCollectionSchema( |
There was a problem hiding this comment.
If the collection has a something in $jsonSchema that can't be parsed as a ValidatorSchema then we treat this as an error. Perhaps we should just log this and continue, in which case we would fall back to sampling for this collection. But I think it's probably better to treat it as an error.
daniel-chambers
approved these changes
Mar 27, 2024
CHANGELOG.md
Outdated
Comment on lines
5
to
12
| - Use separate schema files for each collection | ||
| - Don't sample from collections that already have a schema | ||
| - Changes to `update` CLI command: | ||
| - new default behaviour: | ||
| - attempt to use validator schema if available | ||
| - if no validator schema then sample documents from the collection | ||
| - don't sample from collections that already have a schema | ||
| - if no --sample-size given on command line, default sample size is 10 | ||
| - new option --no-validator-schema to disable attempting to use validator schema |
There was a problem hiding this comment.
Can we link to the PRs for these changelog entries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Attempt to provide some "sensible" default behaviour for the
updatecommand if no command line parameters are given.The idea is to have something that will work well for most users when run from
ddn quickstartorddn dev.--sample-sizeis given on the command line then default to a sample size of 10.--no-validator-schemawhich overrides the default behaviour and prevents the command from attempting to use validator schemas.Issue ticket number and link
MDB-83