Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security vulnerability RUSTSEC-2024-0421 #138

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,24 @@ This changelog documents the changes between release versions.

## [Unreleased]

### Fixed

- Upgrade dependencies to get fix for RUSTSEC-2024-0421, a vulnerability in domain name comparisons ([#138](https://github.com/hasura/ndc-mongodb/pull/138))

#### Fix for RUSTSEC-2024-0421 / CVE-2024-12224

Updates dependencies to upgrade the library, idna, to get a version that is not
affected by a vulnerability reported in [RUSTSEC-2024-0421][].

[RUSTSEC-2024-0421]: https://rustsec.org/advisories/RUSTSEC-2024-0421

The vulnerability allows an attacker to craft a domain name that older versions
of idna interpret as identical to a legitimate domain name, but that is in fact
a different name. We do not expect that this impacts the MongoDB connector since
it uses the affected library exclusively to connect to MongoDB databases, and
database URLs are supplied by trusted administrators. But better to be safe than
sorry.

## [1.5.0] - 2024-12-05

### Added
Expand Down
22 changes: 6 additions & 16 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ It's important to keep the GraphQL Engine version updated to make sure that the
connector is working with the latest engine version. To update run,

```sh
$ nix flake lock --update-input graphql-engine-source
$ nix flake update graphql-engine-source
```

Then commit the changes to `flake.lock` to version control.
Expand All @@ -332,7 +332,7 @@ any order):
To update `rust-overlay` run,

```sh
$ nix flake lock --update-input rust-overlay
$ nix flake update rust-overlay
```

If you are using direnv to automatically apply the nix dev environment note that
Expand Down
2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
# If source changes aren't picked up automatically try:
#
# - committing changes to the local engine repo
# - running `nix flake lock --update-input graphql-engine-source` in this repo
# - running `nix flake update graphql-engine-source` in this repo
# - arion up -d engine
#
graphql-engine-source = {
Expand Down
Loading