implement aggregations on nested fields #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d29fe8a.
…mpose config" This reverts commit 308e841.
codedmart
reviewed
Dec 18, 2024
| ) -> impl Iterator<Item = (AggregationFunction, Type)> { | ||
| let nullable_scalar_type = move || Type::Nullable { | ||
| underlying_type: Box::new(bson_to_named_type(scalar_type)), | ||
| }; |
There was a problem hiding this comment.
Not blocking, but is this useful in other areas as well?
There was a problem hiding this comment.
It could be slightly useful to have a method on ndc_models::Type that does this. That would be a change in the ndc-spec repo. In the connector code we already have configuration::Type::make_nullable.
codedmart
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns on the nested field aggregation connector capability, and makes it work.
This also touches up the aggregation implementation generally. It uses the updated, unified system for referencing fields with paths. It also changes aggregation result types (besides count) to be nullable which avoids an error when aggregating over an empty document set.