update to ndc-spec v0.1.6 to implement support for querying nested collections #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engine support is in now since this release: https://github.com/hasura/v3-engine/releases/tag/v2024.09.02 |
daniel-chambers
approved these changes
Sep 9, 2024
Comment on lines
+1
to
+3
| { "institution": "Black Mesa", "staff": [{ "name": "Freeman" }, { "name": "Calhoun" }] } | ||
| { "institution": "Aperture Science", "staff": [{ "name": "GLaDOS" }, { "name": "Chell" }] } | ||
| { "institution": "City 17", "staff": [{ "name": "Alyx" }, { "name": "Freeman" }, { "name": "Breen" }] } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs some testingAdded unit tests -integration tests will wait until we have engine support for exists-in-nested-collection.Added integration test! Plus a fix that I found was necessary after trying to run the integration test.I added some support for more ad-hoc data for test cases that I worked on recently. I also moved the fixture connector configuration files because twice now I've run into situations where I was wondering why something wasn't working, and then I realized that I wrote configuration to one directory, but the connectors were reading configuration from a subdirectory. That bumped the changed file count for this PR up quite a bit. I recommend not paying much attention to changes in the
fixtures/directory.