allow query root in mutation response (close #1583) #1759

rakeshkky · 2019-03-13T10:18:27Z

Description

Support queries in mutation response.

Example:-

    mutation insert_article {
      insert_article(
        objects: [
          {
            id: 21,
            title: "Article 1",
            content: "Sample article content",
            author_id: 3
          }
        ]
      ) {
        returning {
          id
          title
        }
        query {
          author(where: {id: {_eq: 1}){
            id
            name
          }
        }
      }
    }

Response:-

    {
      "data": {
        "insert_article": {
          "affected_rows": 1,
          "returning": [
            {
              "id": 21,
              "title": "Article 1"
            }
          ],
          "query": {
            "author": [
              {
                "id": 1,
                "name": "Author 1"
              }
            ]
          }
        }
      }
    }

Affected components

Server
Docs
Tests

Related Issues

close #1583

Resolve Conflicts (Cherry Pick): server/tests-py/queries/graphql_mutation/insert/permissions/teardown.yaml

hasura-bot · 2019-03-13T13:28:45Z

Review app for commit 235d5c0 deployed to Heroku: https://hge-ci-pull-1759.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1759-235d5c0

ecthiender · 2019-03-19T05:44:27Z

server/src-lib/Hasura/GraphQL/Context.hs

+mutationRootTy = G.NamedType "mutation_root"
+
+subscriptionRootTy :: G.NamedType
+subscriptionRootTy = G.NamedType "subscription_root"


I think better naming would be queryRootName, mutationRootName etc.

Since those functions give G.NamedType I name them as .....Ty. ...Name is suitable if functions give G.Name.

ecthiender · 2019-03-19T05:44:45Z

server/src-lib/Hasura/GraphQL/Context.hs

@@ -349,12 +357,12 @@ mkGCtx tyAgg (RootFlds flds) insCtxMap =
    colTys    = Set.toList $ Set.fromList $ map pgiType $
                  lefts $ Map.elems fldInfos
    mkMutRoot =
-      mkHsraObjTyInfo (Just "mutation root") (G.NamedType "mutation_root") Set.empty .
+      mkHsraObjTyInfo (Just "mutation root") mutationRootTy Set.empty .


Maybe we can move out the descriptions also, so that can be reused?

ecthiender · 2019-03-19T05:45:04Z

server/src-lib/Hasura/GraphQL/RemoteServer.hs

@@ -152,11 +153,11 @@ mergeMutRoot a b =

 mkNewEmptyMutRoot :: VT.ObjTyInfo
 mkNewEmptyMutRoot = VT.ObjTyInfo (Just "mutation root")


reuse query/mutation descriptions ?

ecthiender · 2019-03-19T05:45:29Z

server/src-lib/Hasura/GraphQL/Resolve.hs

@@ -31,6 +31,7 @@ buildTx userInfo gCtx sqlCtx fld = do
                               , orderByCtx
                               , insCtxMap
                               , sqlCtx
+                               , queryRootResolver
                               ) $ case opCxt of


can we change this code to be more readable? the last argument to run convert, the case matching can be separate?
there is also a typo in opCxt. it should be opCtx.

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Resolve/Introspect.hs server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs server/src-lib/Hasura/RQL/DML/Mutation.hs server/src-lib/Hasura/RQL/DML/Returning.hs server/src-lib/Hasura/RQL/DML/Select.hs

netlify · 2019-03-20T12:32:34Z

Deploy preview for hasura-docs ready!

Built with commit 76ac0c4

https://deploy-preview-1759--hasura-docs.netlify.com

hasura-bot · 2019-03-20T13:07:25Z

Review app for commit 5f50a4f deployed to Heroku: https://hge-ci-pull-1759.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1759-5f50a4f

ecthiender

LGTM

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/DML/Mutation.hs

hasura-bot · 2019-03-22T08:30:30Z

Review app for commit 08e465f deployed to Heroku: https://hge-ci-pull-1759.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1759-08e465f

rikinsk-zz

Removed unqualified query fields in examples. We can add a separate example for the query in mutation use case later on.

rikinsk-zz

docs LGTM

hasura-bot · 2019-03-25T11:20:53Z

Review app for commit a1370f6 deployed to Heroku: https://hge-ci-pull-1759.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1759-a1370f6

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Context.hs server/src-lib/Hasura/GraphQL/Resolve.hs server/src-lib/Hasura/GraphQL/Resolve/Context.hs server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs server/src-lib/Hasura/GraphQL/Resolve/Select.hs

…graphql-engine into issue-1583-query-mut-resp-new

hasura-bot · 2019-03-27T11:12:58Z

Review app for commit d91591c deployed to Heroku: https://hge-ci-pull-1759.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1759-d91591c

Resolve Conflicts: docs/graphql/manual/mutations/delete.rst server/src-lib/Hasura/GraphQL/Explain.hs server/src-lib/Hasura/GraphQL/Resolve.hs server/src-lib/Hasura/GraphQL/Resolve/Context.hs server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Resolve/Mutation.hs server/src-lib/Hasura/GraphQL/Resolve/Select.hs server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/DML/Returning.hs server/src-lib/Hasura/RQL/DML/Select.hs server/src-lib/Hasura/RQL/DML/Select/Internal.hs

hasura-bot · 2019-04-18T10:05:15Z

Review app for commit 7c84b7c deployed to Heroku: https://hge-ci-pull-1759.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1759-7c84b7c

Resolve Conflicts: server/src-lib/Hasura/RQL/DML/Select/Internal.hs server/src-lib/Hasura/RQL/Types/Error.hs

hasura-bot · 2019-05-20T11:32:38Z

Review app for commit 76ac0c4 deployed to Heroku: https://hge-ci-pull-1759.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1759-76ac0c40

CLAassistant · 2019-09-17T10:38:09Z

All committers have signed the CLA.

Stefmore02 · 2023-03-07T16:54:00Z

Closing this PR due to merge conflicts.

rakeshkky added 6 commits March 13, 2019 12:47

allow query root in mutation response, close hasura#1583

f1dd63b

update tests to support queries in mutation

a84d034

Resolve Conflicts (Cherry Pick): server/tests-py/queries/graphql_mutation/insert/permissions/teardown.yaml

update docs

cd5ea22

rename query_mutation to query_root (docs)

9e08044

Merge branch 'master' into issue-1583-query-mut-resp-new

0651312

improve docs, refactor server code

235d5c0

rakeshkky added c/server Related to server c/docs Related to docs labels Mar 13, 2019

rakeshkky self-assigned this Mar 13, 2019

rakeshkky requested review from 0x777 and rikinsk-zz as code owners March 13, 2019 10:18

rakeshkky mentioned this pull request Mar 13, 2019

queries in mutation response (close #1583) #1589

Closed

21 tasks

ecthiender reviewed Mar 19, 2019

View reviewed changes

ecthiender reviewed Mar 20, 2019

View reviewed changes

Merge branch 'master' into issue-1583-query-mut-resp-new

08e465f

Resolve Conflicts: server/src-lib/Hasura/GraphQL/Resolve/Insert.hs server/src-lib/Hasura/GraphQL/Schema.hs server/src-lib/Hasura/RQL/DML/Mutation.hs

rikinsk added 3 commits March 25, 2019 14:39

Update delete.rst

71995a7

Update insert.rst

5ddf428

Update update.rst

a1370f6

rikinsk-zz reviewed Mar 25, 2019

View reviewed changes

rikinsk-zz previously approved these changes Mar 25, 2019

View reviewed changes

Merge branch 'issue-1583-query-mut-resp-new' of github.com:rakeshkky/…

d91591c

…graphql-engine into issue-1583-query-mut-resp-new

rakeshkky dismissed rikinsk-zz’s stale review via d91591c March 27, 2019 10:55

dsandip added this to the release-candidates milestone Apr 15, 2019

Merge branch 'master' into issue-1583-query-mut-resp-new

76ac0c4

Resolve Conflicts: server/src-lib/Hasura/RQL/DML/Select/Internal.hs server/src-lib/Hasura/RQL/Types/Error.hs

tirumaraiselvan removed this from the release-candidates milestone Mar 13, 2020

Stefmore02 closed this Mar 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow query root in mutation response (close #1583) #1759

allow query root in mutation response (close #1583) #1759

rakeshkky commented Mar 13, 2019

hasura-bot commented Mar 13, 2019

ecthiender Mar 19, 2019

rakeshkky Mar 19, 2019

ecthiender Mar 19, 2019

ecthiender Mar 19, 2019 •

edited

Loading

ecthiender Mar 19, 2019

netlify bot commented Mar 20, 2019 •

edited

Loading

hasura-bot commented Mar 20, 2019

ecthiender left a comment

hasura-bot commented Mar 22, 2019

rikinsk-zz left a comment •

edited

Loading

rikinsk-zz left a comment

hasura-bot commented Mar 25, 2019

hasura-bot commented Mar 27, 2019

hasura-bot commented Apr 18, 2019

hasura-bot commented May 20, 2019

CLAassistant commented Sep 17, 2019 •

edited

Loading

Stefmore02 commented Mar 7, 2023

		@@ -152,11 +153,11 @@ mergeMutRoot a b =

		mkNewEmptyMutRoot :: VT.ObjTyInfo
		mkNewEmptyMutRoot = VT.ObjTyInfo (Just "mutation root")

allow query root in mutation response (close #1583) #1759

allow query root in mutation response (close #1583) #1759

Conversation

rakeshkky commented Mar 13, 2019

Description

Affected components

Related Issues

hasura-bot commented Mar 13, 2019

ecthiender Mar 19, 2019

Choose a reason for hiding this comment

rakeshkky Mar 19, 2019

Choose a reason for hiding this comment

ecthiender Mar 19, 2019

Choose a reason for hiding this comment

ecthiender Mar 19, 2019 • edited Loading

Choose a reason for hiding this comment

ecthiender Mar 19, 2019

Choose a reason for hiding this comment

netlify bot commented Mar 20, 2019 • edited Loading

hasura-bot commented Mar 20, 2019

ecthiender left a comment

Choose a reason for hiding this comment

hasura-bot commented Mar 22, 2019

rikinsk-zz left a comment • edited Loading

Choose a reason for hiding this comment

rikinsk-zz left a comment

Choose a reason for hiding this comment

hasura-bot commented Mar 25, 2019

hasura-bot commented Mar 27, 2019

hasura-bot commented Apr 18, 2019

hasura-bot commented May 20, 2019

CLAassistant commented Sep 17, 2019 • edited Loading

Stefmore02 commented Mar 7, 2023

ecthiender Mar 19, 2019 •

edited

Loading

netlify bot commented Mar 20, 2019 •

edited

Loading

rikinsk-zz left a comment •

edited

Loading

CLAassistant commented Sep 17, 2019 •

edited

Loading