Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify SQL generated for _eq and _neq operators in GraphQL API #1466

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

rakeshkky
Copy link
Member

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Use simple = for _eq and <> for _neq operators

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@rakeshkky rakeshkky added s/ok-to-merge Status: This pull request can be merged to master c/server Related to server labels Jan 24, 2019
@rakeshkky rakeshkky self-assigned this Jan 24, 2019
@rakeshkky rakeshkky requested a review from 0x777 January 24, 2019 15:17
@hasura-bot
Copy link
Contributor

Review app for commit c43679e deployed to Heroku: https://hge-ci-pull-1466.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1466-c43679e

@hasura-bot
Copy link
Contributor

Review app for commit 4bbd6b4 deployed to Heroku: https://hge-ci-pull-1466.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1466-4bbd6b4

@0x777 0x777 merged commit ae63ed9 into hasura:master Jan 24, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1466.herokuapp.com is deleted

@0x777 0x777 modified the milestone: v1.0.0-alpha36 Jan 28, 2019
hasura-bot pushed a commit that referenced this pull request Dec 23, 2024
Bumps [expect-test](https://github.com/rust-analyzer/expect-test) from
1.5.0 to 1.5.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rust-analyzer/expect-test/blob/master/CHANGELOG.md">expect-test's
changelog</a>.</em></p>
<blockquote>
<h1>1.5.1</h1>
<ul>
<li>Documentation improvements</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/rust-analyzer/expect-test/commit/9e616f9e8e94cd80b0f09155b7d9b4c57e133dbc"><code>9e616f9</code></a>
Merge pull request <a
href="https://redirect.github.com/rust-analyzer/expect-test/issues/53">#53</a>
from xxchan/xxchan/interim-tarantula</li>
<li><a
href="https://github.com/rust-analyzer/expect-test/commit/fc87d4e749b363d13b4f5df64dc31caf50789da8"><code>fc87d4e</code></a>
update README</li>
<li><a
href="https://github.com/rust-analyzer/expect-test/commit/7e3092f269fac2e04b307ab490033d529f6ac210"><code>7e3092f</code></a>
bump version</li>
<li><a
href="https://github.com/rust-analyzer/expect-test/commit/8aff4a94044e727c91d22b08fe91f0a39b2dbb67"><code>8aff4a9</code></a>
doc: update the recommended placeholder</li>
<li>See full diff in <a
href="https://github.com/rust-analyzer/expect-test/compare/v1.5.0...v1.5.1">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=expect-test&package-manager=cargo&previous-version=1.5.0&new-version=1.5.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
V3_GIT_ORIGIN_REV_ID: 5b89e1746c5355bfcd3d3073f10430ee696c1adf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Related to server s/ok-to-merge Status: This pull request can be merged to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants