Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encourage good security in email checking! #1421

Merged
merged 1 commit into from
Jan 24, 2019
Merged

encourage good security in email checking! #1421

merged 1 commit into from
Jan 24, 2019

Conversation

samuela
Copy link
Contributor

@samuela samuela commented Jan 21, 2019

The current regex is vulnerable to all sorts of attacks: [email protected] or [email protected].

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

The current regex is vulnerable to all sorts of attacks: `[email protected]` or `[email protected]`.
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @samuela, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

Review app for commit 0144cfc deployed to Heroku: https://hge-ci-pull-1421.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1421-0144cfc

@rikinsk-zz rikinsk-zz requested a review from ecthiender January 21, 2019 08:46
Copy link
Member

@ecthiender ecthiender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the catching it!

@0x777 0x777 merged commit e7a42c6 into hasura:master Jan 24, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1421.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @samuela! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

@samuela samuela deleted the patch-2 branch January 24, 2019 18:55
hasura-bot pushed a commit that referenced this pull request Dec 9, 2024
<!-- The PR description should answer 2 important questions: -->

### What

Final part of execution plan changes. There was a bunch of code and
types shared between `graphql_ir` and `plan`. They were in `graphql_ir`
but now they're in `plan`, flipping the dependency.

There is other stuff in `graphql_ir` which will end up in `plan` in due
course as more features are implemented in the new pipeline.

Functional no-op.

V3_GIT_ORIGIN_REV_ID: 05dd50e75aeb681be329dd7d6061f4258459fbfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants