Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscription goroutine leaks #162

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Conversation

hgiasac
Copy link

@hgiasac hgiasac commented Feb 9, 2025

close #160

  • The main runner will be a singleton. Get rid of the recursive loop to avoid goroutine leaks
  • Enhance the error handling. Add 2 new timeout settings WithConnectionInitialisationTimeout and WithWebsocketConnectionIdleTimeout to handle errors when the server is unresponsive. Check out the docs for more details.

Copy link

github-actions bot commented Feb 10, 2025

Code Coverage

Package Line Rate Health
github.com/hasura/go-graphql-client 66%
github.com/hasura/go-graphql-client/ident 100%
github.com/hasura/go-graphql-client/pkg/jsonutil 84%
Summary 70% (1540 / 2189)

Minimum allowed line rate is 60%

@hgiasac hgiasac marked this pull request as ready for review February 10, 2025 08:06
@hgiasac hgiasac merged commit 5970b87 into master Feb 19, 2025
2 checks passed
@hgiasac hgiasac deleted the fix/subscription-goroutine-leaks branch February 19, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock in subscription client
1 participant