Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Unifi controller to 7.5.176 (latest) #455

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Bump Unifi controller to 7.5.176 (latest) #455

merged 1 commit into from
Oct 14, 2023

Conversation

cwmoriarty
Copy link
Contributor

@cwmoriarty cwmoriarty commented Oct 14, 2023 •
edited
Loading

Proposed Changes

Update Dockerfile to pull Unifi controller 7.5.176 and OpenJDK 17.

frenck
frenck requested changes Oct 14, 2023
View reviewed changes
unifi/Dockerfile
@@ -14,10 +14,10 @@ RUN \
libcap2=1:2.32-1 \
logrotate=3.14.0-4ubuntu3 \
mongodb-server=1:3.6.9+really3.6.8+90~g8e540c0b6d-0ubuntu5.3 \
openjdk-11-jdk-headless=11.0.19+7~us1-0ubuntu1~20.04.1 \
openjdk-17-jdk-headless=17* \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be pinned strictly.

Copy link
Member

@frenck frenck Oct 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this package doesn't even exist.. Ubuntu frenck... ubuntu...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the amd64 version has some security updates.

Unless we add some logic here to switch based on architecture... it will be ugly.

Let's slide this in as is.

@frenck
Copy link
Member

frenck commented Oct 14, 2023 •
edited
Loading

Closing this PR, as you didn't test it (as the package referenced doesn't even exist).

Please stop wasting time of people by doing this stuff. If you make a PR on any project, make sure you have at least tested it.

God, the mess I made here. Please accept my apologies. Been working on Alpine-based add-ons the past hours. So I looked in the Alpine package index 🤦‍♂️

I will check if I can pin it a little more strict, but I see there are versioning differences between the architectures; so I understand why you did the loose pin.

../Frenck

@frenck frenck closed this Oct 14, 2023
@frenck frenck reopened this Oct 14, 2023
@frenck frenck added dependencies Upgrade or downgrade of project dependencies. minor This PR causes a minor version bump in the version number. labels Oct 14, 2023
frenck
frenck approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cwmoriarty 👍

And sorry about the misunderstanding above.

../Frenck

@frenck frenck merged commit 27e9f73 into hassio-addons:main Oct 14, 2023
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
dependencies Upgrade or downgrade of project dependencies. minor This PR causes a minor version bump in the version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwmoriarty @frenck