Fix base image update

[lmagyar]

Proposed Changes

/usr/libexec/nm-dispatcher is moved from networkmanager-common to networkmanager, not networkmanager-cli

Related Issues

Summary by CodeRabbit

• New Features
  • Updated the NetworkManager package to the full version for improved functionality.
• Bug Fixes
  • Resolved issues related to the previous command-line interface version of NetworkManager.

[coderabbitai]

Walkthrough

The Tailscale Dockerfile has been modified to change the package name from networkmanager-cli=1.50.0-r3 to networkmanager=1.50.0-r3. This change reflects an update from a command-line interface version to the full version of NetworkManager. The rest of the Dockerfile remains unchanged, preserving the base image, shell settings, and installation commands for other packages, while build arguments and labels are intact.

Changes

File	Change Summary
tailscale/Dockerfile	Updated package name from networkmanager-cli=1.50.0-r3 to networkmanager=1.50.0-r3.

Possibly related PRs

• ⬆️ Update Add-on base image to v16.2.1 #395: This PR updates the Dockerfile for the Tailscale project by changing the base image version, which is related to the Dockerfile modifications in the main PR.

Suggested labels

dependencies

Suggested reviewers

• frenck

Poem

In the Dockerfile, a change we see,
From CLI to full, how grand it be!
NetworkManager takes its place,
In Tailscale's world, it finds its space.
With each build, we hop and cheer,
For updates bright, we hold so dear! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7011ffd and 037557a.

📒 Files selected for processing (1)

• tailscale/Dockerfile (1 hunks)

🔇 Additional comments (2)

tailscale/Dockerfile (2)

19-19: LGTM: Package change addresses the nm-dispatcher relocation

The change from networkmanager-cli to networkmanager correctly addresses the relocation of the /usr/libexec/nm-dispatcher file to the main NetworkManager package.

---

19-19: Verify the image size impact

Switching from networkmanager-cli to the full networkmanager package might increase the final image size.

Let's check the package size difference:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[frenck]

Thanks, @lmagyar 👍

../Frenck