Fix new default value for stateful_filtering in documentation #369
Conversation
WalkthroughThe primary change involves updating the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
lmagyar
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (7)
tailscale/DOCS.md (7)
Line range hint
11-11: Consider rephrasing to avoid wordiness. For example, "Tailscale works everywhere you are."
Line range hint
20-20: The word "however" should be preceded by a semicolon or start a new sentence to improve readability.- You can also create an account during the add-on installation processes, however, it is nice to know where you need to go later on. + You can also create an account during the add-on installation processes; however, it is nice to know where you need to go later on.
Line range hint
61-61: Consider adding a comma after "Web UI" for better readability.- Some of the options below also available on Tailscale's web interface through the Web UI, but they are made read only there. + Some of the options below also available on Tailscale's web interface through the Web UI, but they are made read only there.
Line range hint
94-94: Add a comma after "In such cases" to improve the flow of the sentence.- In such cases disabling `accept_dns` will help. + In such cases, disabling `accept_dns` will help.
Line range hint
195-195: Remove the comma before "because" as it introduces an essential clause.- Turn it on only in case you are troubleshooting, because Tailscale's daemon is quite chatty. + Turn it on only in case you are troubleshooting because Tailscale's daemon is quite chatty.
Line range hint
218-218: Correct the grammatical error by removing "to" after "lets you".- This option lets you to specify a custom control server instead of the default. + This option lets you specify a custom control server instead of the default.
Line range hint
282-282: Correct the abbreviation "e.g." to include two periods.- Site-to-site networking][tailscale_info_site_to_site] (eg. to traverse multiple networks) + Site-to-site networking][tailscale_info_site_to_site] (e.g. to traverse multiple networks)
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tailscale/DOCS.md (1 hunks)
Additional Context Used
LanguageTool (20)
tailscale/DOCS.md (20)
Near line 11: Consider a shorter alternative to avoid wordiness.
Context: ...om anywhere you are. ## Prerequisites In order to use this add-on, you'll need a Tailscal...
Near line 20: The word “however” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...during the add-on installation processes, however, it is nice to know where you need to go...
Near line 61: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...You can't change them through the Web UI, because all the changes made there would be los...
Near line 61: Consider adding a comma.
Context: ...the Web UI, because all the changes made there would be lost when the add-on is restar...
Near line 94: Possible missing comma found.
Context: ...he same machine as this add-on. In such cases disablingaccept_dnswill help. You c...
Near line 195: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ... on only in case you are troubleshooting, because Tailscale's daemon is quite chatty. If ...
Near line 203: Loose punctuation mark.
Context: ...n issue. Possible values are: -trace: Show every detail, like all called inte...
Near line 204: Loose punctuation mark.
Context: ...all called internal functions. -debug: Shows detailed debug information. - `in...
Near line 205: Loose punctuation mark.
Context: ...ows detailed debug information. -info: Normal (usually) interesting events. - ...
Near line 206: Loose punctuation mark.
Context: ...(usually) interesting events. -notice: Normal but significant events. - `warni...
Near line 207: Loose punctuation mark.
Context: ...rmal but significant events. -warning: Exceptional occurrences that are not er...
Near line 208: Loose punctuation mark.
Context: ...currences that are not errors. -error: Runtime errors that do not require imme...
Near line 209: Loose punctuation mark.
Context: ... not require immediate action. -fatal: Something went terribly wrong. Add-on b...
Near line 218: Using the to-infinitive may not be correct in this context. Consider using the bare infinitive (without “to”) instead.
Context: ...n:login_serverThis option lets you to specify a custom control server instead of the ...
Near line 230: “of” seems less likely than “if” (in case).
Context: ...ook unencrypted (browsers are not aware of the connections between Tailscale nodes...
Near line 282: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...tworking][tailscale_info_site_to_site] (eg. to traverse multiple networks), you can...
Near line 326: Possible missing comma found.
Context: ...ou want to access other clients on your tailnet even from your local subnet, follow ste...
Near line 345: Loose punctuation mark.
Context: ...ented based on the following: -MAJOR: Incompatible or major changes. - `MINOR...
Near line 346: Loose punctuation mark.
Context: ...Incompatible or major changes. -MINOR: Backwards-compatible new features and e...
Near line 347: Loose punctuation mark.
Context: ...new features and enhancements. -PATCH: Backwards-compatible bugfixes and packa...
Additional comments not posted (1)
tailscale/DOCS.md (1)
78-78: Correctly updated the default value forstateful_filtering.
Proposed Changes
SSIA
Related Issues
--
Summary by CodeRabbit
stateful_filteringsetting tofalseto modify the behavior related to stateful filtering.