Stateful filtering is now off by default

[lmagyar]

Proposed Changes

In TS v1.66.4 stateful filtering is off by default, the add-on follows this change. https://github.com/tailscale/tailscale/releases/tag/v1.66.4

Related Issues

--

Summary by CodeRabbit

• Documentation

  • Clarified instructions for site-to-site networking in Tailscale documentation.
  • Updated default setting information for a specific option, now disabled by default.

• New Features

  • Enabled stateful filtering by default in the post-tailscaled/run script starting from version 1.66.4.

[coderabbitai]

Warning

Rate Limit Exceeded

@lmagyar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 48 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between a9bf7e2 and 347bb0e.

Walkthrough

The recent updates to Tailscale's documentation and configuration scripts involve changing the default settings for certain options. Notably, an option related to stateful packet filtering is now disabled by default, and site-to-site networking instructions have been clarified. Additionally, the post-tailscaled/run script has been updated to enable stateful filtering by default starting from version 1.66.4.

Changes

File Path	Change Summary
tailscale/DOCS.md	Default setting for an option changed to disabled; clarified site-to-site networking instructions.
tailscale/rootfs/.../post-tailscaled/run	Enabled stateful filtering by default in the script from version 1.66.4 onwards.
tailscale/translations/en.yaml	Updated default state of an option related to stateful packet filtering to disabled.

🐰 In the code, a change was made,
Stateful filters now cascade.
Defaults shift and docs refine,
Networking paths now clearly align.
Through the bytes, a rabbit hops,
Celebrating code with joyful props. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 724ca2c and a9bf7e2.

Files selected for processing (3)

• tailscale/DOCS.md (2 hunks)
• tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run (1 hunks)
• tailscale/translations/en.yaml (1 hunks)

Files skipped from review due to trivial changes (1)

• tailscale/translations/en.yaml

Additional Context Used

LanguageTool (20)

tailscale/DOCS.md (20)

Near line 11: Consider a shorter alternative to avoid wordiness.
Context: ...om anywhere you are. ## Prerequisites In order to use this add-on, you'll need a Tailscal...

---

Near line 20: The word “however” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...during the add-on installation processes, however, it is nice to know where you need to go...

---

Near line 61: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...You can't change them through the Web UI, because all the changes made there would be los...

---

Near line 61: Consider adding a comma.
Context: ...the Web UI, because all the changes made there would be lost when the add-on is restar...

---

Near line 94: Possible missing comma found.
Context: ...he same machine as this add-on. In such cases disabling accept_dns will help. You c...

---

Near line 195: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ... on only in case you are troubleshooting, because Tailscale's daemon is quite chatty. If ...

---

Near line 203: Loose punctuation mark.
Context: ...n issue. Possible values are: - trace: Show every detail, like all called inte...

---

Near line 204: Loose punctuation mark.
Context: ...all called internal functions. - debug: Shows detailed debug information. - `in...

---

Near line 205: Loose punctuation mark.
Context: ...ows detailed debug information. - info: Normal (usually) interesting events. - ...

---

Near line 206: Loose punctuation mark.
Context: ...(usually) interesting events. - notice: Normal but significant events. - `warni...

---

Near line 207: Loose punctuation mark.
Context: ...rmal but significant events. - warning: Exceptional occurrences that are not er...

---

Near line 208: Loose punctuation mark.
Context: ...currences that are not errors. - error: Runtime errors that do not require imme...

---

Near line 209: Loose punctuation mark.
Context: ... not require immediate action. - fatal: Something went terribly wrong. Add-on b...

---

Near line 218: Using the to-infinitive may not be correct in this context. Consider using the bare infinitive (without “to”) instead.
Context: ...n: login_server This option lets you to specify a custom control server instead of the ...

---

Near line 230: “of” seems less likely than “if” (in case).
Context: ...ook unencrypted (browsers are not aware of the connections between Tailscale nodes...

---

Near line 282: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...tworking][tailscale_info_site_to_site] (eg. to traverse multiple networks), you can...

---

Near line 326: Possible missing comma found.
Context: ...ou want to access other clients on your tailnet even from your local subnet, execute st...

---

Near line 345: Loose punctuation mark.
Context: ...ented based on the following: - MAJOR: Incompatible or major changes. - `MINOR...

---

Near line 346: Loose punctuation mark.
Context: ...Incompatible or major changes. - MINOR: Backwards-compatible new features and e...

---

Near line 347: Loose punctuation mark.
Context: ...new features and enhancements. - PATCH: Backwards-compatible bugfixes and packa...

Additional comments not posted (2)

tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run (1)

75-81: Update to stateful filtering logic aligns with Tailscale v1.66.4 changes.

This change correctly implements the new default behavior for stateful filtering as described in the PR. It's important to ensure that the documentation and user interface clearly communicate this new default to avoid confusion.

tailscale/DOCS.md (1)

295-295: Clarification in documentation about stateful filtering default state.

The documentation update correctly reflects the new default behavior for stateful filtering. It's crucial that users are aware of this change, especially if they rely on previous configurations.

[frenck]

Thanks, @lmagyar 👍

../Frenck