Skip default networks without a gateway to enable UDP GRO for forwarding

[lmagyar]

Proposed Changes

Skip default networks without a gateway to enable UDP GRO for forwarding

default via xxxx dev xxxx ... # This is OK 
default dev xxxx ... # This is skipped 

Related Issues

fixes #364

Summary by CodeRabbit

• Enhancements
  • Improved route filtering in the network configuration script to better select interfaces.

[coderabbitai]

Walkthrough

The change involves updating the post-tailscaled/run script to include a grep command that filters routes with the pattern 'default via dev '. This enhancement aims to improve the script's functionality by refining the selection of network interfaces, addressing issues where Tailscale fails to start on HA Yellow.

Changes

Files	Change Summary
tailscale/.../s6-rc.d/post-tailscaled/run	Added a grep command to filter routes with the pattern 'default via dev '

Assessment against linked issues

Objective	Addressed	Explanation
Tailscale fails to start on HA Yellow after updating to 0.19.0 (#364)	✅
Error messages related to netlink error: no device matches name (#364)	✅
Modification to post-tailscaled script to improve interface selection (#364)	✅

Poem

In the code, a change so bright,
To guide the routes, a beacon light,
With grep we find the path so clear,
Now Tailscale starts without a fear.
On HA Yellow, it runs with grace,
A happy smile on every face.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 724ca2c and e299d34.

Files selected for processing (1)

• tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run (1 hunks)

Files skipped from review due to trivial changes (1)

• tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run

[frenck]

Thanks, @lmagyar 👍

../Frenck