Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #274

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Oct 17, 2023

Proposed Changes

Typos, consistent formatting, consistent wording, alphabetical order after the mega-merge in v0.12.0.

One functional improvement: Protect local subnets only if non-userspace networking is used and accepting routes are enabled.

Related Issues

@lmagyar lmagyar force-pushed the pr-tweaks-after-mega-merge branch 2 times, most recently from 1a16523 to 5a62c4c Compare October 18, 2023 08:34
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unrelated commits.

@frenck frenck marked this pull request as draft October 18, 2023 13:17
@lmagyar lmagyar force-pushed the pr-tweaks-after-mega-merge branch 2 times, most recently from dea3c4c to f20f925 Compare October 20, 2023 15:45
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 20, 2023

Rebased, to prevent merge conflicts.

@lmagyar lmagyar force-pushed the pr-tweaks-after-mega-merge branch 2 times, most recently from 7b0925a to adb30dd Compare October 23, 2023 16:02
@frenck frenck added the documentation Solely about the documentation of the project. label Oct 23, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 23, 2023

Moved the only functional change into separate PR. This is only docs and log messages change.

@lmagyar lmagyar marked this pull request as ready for review October 23, 2023 16:20
@frenck
Copy link
Member

frenck commented Oct 23, 2023

@lmagyar Can you rebase this PR? I think it would be nice to include in the next cut

…d AND accepting routes are enabled"

This reverts commit d2fabc1.

# Conflicts:
#	tailscale/rootfs/etc/s6-overlay/s6-rc.d/post-tailscaled/run
@lmagyar lmagyar force-pushed the pr-tweaks-after-mega-merge branch from 1f519aa to c20d562 Compare October 23, 2023 18:46
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 23, 2023

Rebased - with some manual conflict resolution, git gone wild.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit 715fe84 into hassio-addons:main Oct 23, 2023
11 checks passed
@lmagyar lmagyar deleted the pr-tweaks-after-mega-merge branch October 23, 2023 19:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Solely about the documentation of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants