Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgrade Tailscale to 1.30.1 #108

Merged
merged 5 commits into from
Sep 15, 2022
Merged

⬆️ Upgrade Tailscale to 1.30.1 #108

merged 5 commits into from
Sep 15, 2022

Conversation

jeffothy
Copy link
Contributor

@jeffothy jeffothy commented Sep 1, 2022 •
edited by frenck
Loading

@frenck frenck added the dependencies Upgrade or downgrade of project dependencies. label Sep 1, 2022
frenck
frenck requested changes Sep 3, 2022
View reviewed changes
tailscale/Dockerfile Outdated
@@ -13,7 +13,7 @@ RUN \
ipcalc=1.0.1-r0 \
iproute2=5.17.0-r0 \
iptables=1.8.8-r1 \
nginx=1.22.0-r0 \
nginx=1.22.0-r1 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to this PR, please revert it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Are you going to fix this nginx dep bump in another PR then?

Builds fail without it due to:

ERROR: unable to select packages:
  nginx-1.22.0-r1:
    breaks: world[nginx=1.22.0-r0]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created #109 for that purpose. Hopefully that helps!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Are you going to fix this nginx dep bump in another PR then?

Builds fail without it due to:


ERROR: unable to select packages:

  nginx-1.22.0-r1:

    breaks: world[nginx=1.22.0-r0]

Sure, when I have time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, when I have time.

No problem! Perhaps you missed my other comment above. I tested #109 build locally and it appears to be good to go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mis it, I am abroad not able to work on things.

@jeffothy jeffothy requested a review from frenck September 3, 2022 17:14
frenck
frenck reviewed Sep 15, 2022
View reviewed changes
tailscale/Dockerfile Outdated Show resolved Hide resolved
@frenck frenck changed the title ⬆️ Upgrade Tailscale to 1.30.0 ⬆️ Upgrade Tailscale to 1.30.1 Sep 15, 2022
frenck
frenck approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeffothy 👍

@frenck frenck merged commit 6be6bff into hassio-addons:main Sep 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffothy @frenck