Include procps by default for Visual Studio Code #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
requested changes
Apr 15, 2024
frenck
changed the title
frenck
added
the
enhancement
frenck
approved these changes
Apr 17, 2024
|
Why did you push a commit? Was it needed? Something broken? Was there a conflict? |
I saw that it didn't build and that the errors were around packages that were updated on |
|
Thanks for the info, sorry, wasn't sure. As it caused a change after approval, without any comment. |
frenck
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Seems like the
pscommand included in Alpine is not enough anymore.Adding this to the documentation, but maybe it makes more sense to have it in the Dockerfile?Adding
procpsto the Dockerfile, so that's included and Visual Studio Code remote-ssh can connect out-of-the-boxRelated Issues
Fixes #722