Fix bash; use hash mark in root prompt #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
force-pushed
the
fix/root-bash-hash-prompt
branch
from
1f07eb2 to
ac601c5
Compare
scop
changed the title
frenck
changed the title
|
Renamed the subject to be human instead of that horrible commit "Conventional Commits" specification. I wish that could be eradicated from the planet. We are humans, let's communicate as such. |
frenck
added
the
bugfix
frenck
requested changes
Nov 20, 2022
| @@ -1,4 +1,9 @@ | |||
| export PS1='\W $ ' | |||
| export PS1='\W' | |||
| if [ "${USER-}" = root ]; then | |||
There was a problem hiding this comment.
We are always root, not sure why this is needed in that case?
There was a problem hiding this comment.
We are always root, except when we aren't :) For example, after a sudo -s -u hassio for whatever reason. Granted, it's rare, but I don't see why we wouldn't just do the right thing here.
`#` for root, `$` for non-root is a long standing tradition in bash. Presenting the dollar for root may lead to dangerous incorrect assumptions.
frenck
force-pushed
the
fix/root-bash-hash-prompt
branch
from
ac601c5 to
7d25eef
Compare
frenck
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
#for root,$for non-root is a long standing tradition in bash and some other shells. Presenting$for root is kind of dangerous as it causes incorrect assumptions about the powers at hand.I don't know but I suppose
/etc/profile.dsnippets are loaded by zsh as well, but the zsh prompt looks quite different; I believe it gets rewritten later on on purpose. And maybe the hash vs dollar tradition isn't a thing for it in the first place, so this change should be good from that point of view.