Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash completion #462

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Fix bash completion #462

merged 1 commit into from
Nov 7, 2022

Conversation

joshuaspence
Copy link
Contributor

Proposed Changes

Bash completion is broken in the latest release. This PR fixes it.

~ $ ha <TAB> 
.bash_history  .config/       .lesshst       .ssh/          .viminfo       .zshrc         backup/        media/         ssl/           
.bash_profile  .gitconfig     .oh-my-zsh/    .tmux.conf     .vimrc         addons/        config/        share/

Related Issues

#460 fixed completion for zsh but not for bash.

@joshuaspence
Copy link
Contributor Author

Hm, I don't think I have permission to add labels

@tjorim tjorim added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Nov 4, 2022
@tjorim tjorim mentioned this pull request Nov 4, 2022
Closed
frenck
frenck approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joshuaspence 👍

@frenck frenck merged commit ec385ce into hassio-addons:main Nov 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuaspence @frenck @tjorim