🔥 Remove STDIN service #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This removed the stdin service from this add-on.
It makes it too easy to run an arbitrary command from a simple service call from within Home Assistant; which potentially can lead to security issues. The service by itself requires one to be authenticated and therefore is not less secure compared to e.g., the terminal itself (which gives you the exact same power).
Rather social engineering can be a factor, although requires a lot of steps. To prevent such discussions this service is removed.
As a replacement, you can use the
sshcommand directly to achieve the same result; which is generally available and not specific to this add-on.