Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of secrets #21

Merged
merged 7 commits into from
Aug 19, 2018
Merged

Allow the use of secrets #21

merged 7 commits into from
Aug 19, 2018

Conversation

tjorim
Copy link
Contributor

@tjorim tjorim commented Aug 18, 2018

Just trying things out for myself, no need to accept this PR if it's too ugly or hacky 😉

Edit: not sure yet if it would even work

@ghost ghost assigned tjorim Aug 18, 2018
@addons-assistant
Copy link

💖 Thanks for opening this pull request! 💖 If your PR gets accepted and merged in, we will invite you to the project 🎉

And clarify that user permission doesn't support secrets
At least when the doors are open
@tjorim tjorim changed the title WIP: Allow the use of secrets Allow the use of secrets Aug 18, 2018
@tjorim
Copy link
Contributor Author

tjorim commented Aug 18, 2018

I think it should work but I'm not able to test it because of some weird error in a file I didn't even touch.

[cont-init.d] 10-requirements.sh: executing... 
exec: fatal: unable to exec bash: No such file or directory
[cont-init.d] 10-requirements.sh: exited 111.

@ghost ghost assigned frenck Aug 19, 2018
@frenck
Copy link
Member

frenck commented Aug 19, 2018

Thank you for this!

bitmoji

@frenck frenck merged commit 95feee7 into hassio-addons:master Aug 19, 2018
@addons-assistant
Copy link

Congrats on merging your first pull request! 🎉🎉🎉

@tjorim tjorim deleted the secrets-patch branch August 19, 2018 15:03
@dethpickle
Copy link

Hey guys, quick question - and forgive me, I couldn't find any info about how to use this aside from the reference in the change log. Is that we can now use !secret whatever in the Hassio config text or can we now use !secret in the configuration of nodes inside node-red? Or both?

And thanks for this! Spreading passwords around files makes for maintenance headaches.

@frenck
Copy link
Member

frenck commented Aug 20, 2018

Hi there @dethpickle,

Please do not use merged PR's or GitHub issues for generic support questions.
Instead join or Discord: https://discord.me/hassioaddons
Or, check out the dedicated topic for this add-on on the Home Assistant Community forums.

Regarding your question: This only work from within the add-on configuration context (so not from within Node-RED).

@hassio-addons hassio-addons locked and limited conversation to collaborators Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants