Increase PHP memory limit

[creuzerm]

I get a out of memory error when I try to add items to a shopping cart, this fixes it.

Proposed Changes

I get an out of memory error when I try to use the Add Item button on the Shopping Cart page. Adding a higher than PHP default memory allocation in the ini file fixes this for me.

Error log I was getting.

Error Log

---

Add-on: Grocy
ERP beyond your fridge! A groceries & household management solution for your home

Add-on version: 0.21.0
You are running the latest version of this add-on.
System: Home Assistant OS 12.0 (amd64 / qemux86-64)
Home Assistant Core: 2024.2.3
Home Assistant Supervisor: 2024.02.0

Please, share the above information when looking for help
or support in, e.g., GitHub, forums or the Discord chat.

s6-rc: info: service base-addon-banner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service base-addon-log-level: starting
s6-rc: info: service base-addon-log-level successfully started
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service init-php-fpm: starting
s6-rc: info: service init-nginx: starting
s6-rc: info: service init-grocy: starting
[11:05:04] INFO: Patching Grocy to fix relative URL handling...
patching file views/layout/default.blade.php
s6-rc: info: service init-grocy successfully started
s6-rc: info: service init-php-fpm successfully started
s6-rc: info: service php-fpm: starting
s6-rc: info: service php-fpm successfully started
[11:05:07] INFO: Starting PHP-FPM...
s6-rc: info: service init-nginx successfully started
s6-rc: info: service nginx: starting
s6-rc: info: service nginx successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
[11:05:23] INFO: Starting NGinx....
2024/02/26 11:15:32 [error] 406#406: *66 FastCGI sent in stderr: "PHP message: PHP Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 4096 bytes) in /var/www/grocy/packages/morris/lessql/src/LessQL/Row.php on line 72" while reading response header from upstream, client: 172.30.32.2, server: a0d7b954-grocy, request: "GET /shoppinglist HTTP/1.1", upstream: "fastcgi://127.0.0.1:9002", host: "192.168.86.3:8123", referrer: "http://192.168.86.3:8123/api/hassio_ingress/M9dKdl4JBY4tFPvFcITqhEXITThb0fcnzgezzEWE0us/stockoverview"
2024/02/26 11:15:39 [error] 406#406: *66 FastCGI sent in stderr: "PHP message: PHP Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 4096 bytes) in /var/www/grocy/packages/morris/lessql/src/LessQL/Row.php on line 72" while reading response header from upstream, client: 172.30.32.2, server: a0d7b954-grocy, request: "GET /shoppinglist HTTP/1.1", upstream: "fastcgi://127.0.0.1:9002", host: "192.168.86.3:8123", referrer: "http://192.168.86.3:8123/api/hassio_ingress/M9dKdl4JBY4tFPvFcITqhEXITThb0fcnzgezzEWE0us/stockoverview"

Trying 256M

2024/04/23 09:45:37 [error] 376#376: *23 FastCGI sent in stderr: "PHP message: PHP Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 1454080 bytes) in /data/grocy/viewcache/e46b19eab9c9eedb43a91cd9d707cc1e.php on line 10" while reading response header from upstream, client: 172.30.32.2, server: a0d7b954-grocy, request: "GET /shoppinglistitem/new?embedded=&list=1 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9002", host: "192.168.86.3:8123", referrer: "http://192.168.86.3:8123/api/hassio_ingress/M9dKdl4JBY4tFPvFcITqhEXITThb0fcnzgezzEWE0us/shoppinglist"

Summary by CodeRabbit

• Improvements
  • Increased PHP memory limit to 384MB to enhance performance and handle larger data processing tasks more efficiently.

[creuzerm]

I can't seem to add a label to get the merge to pass verification.

[frenck]

I can't seem to add a label to get the merge to pass verification.

Correct, the PR labels are something only maintainers/collaborators can set on GitHub. Nothing we or you can do about that.

[coderabbitai]

Walkthrough

The recent update involves modifying the PHP configuration file for Grocy. Specifically, the memory_limit directive was set to 384 megabytes to ensure the application has sufficient memory resources for optimal performance.

Changes

File Path	Change Summary
grocy/rootfs/etc/php82/conf.d/99-grocy.ini	Added memory_limit = 384M directive.

In a world of code so bright and fair,
A rabbit hops without a care.
With memory now set to 384M,
Grocy runs smooth, like a gem.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ff0289 and c520753.

Files selected for processing (1)

• grocy/rootfs/etc/php82/conf.d/99-grocy.ini (1 hunks)

Files skipped from review due to trivial changes (1)

• grocy/rootfs/etc/php82/conf.d/99-grocy.ini

[frenck]

Thanks, @creuzerm 👍

../Frenck