-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-on library for recoverable signatures #45
base: master
Are you sure you want to change the base?
Conversation
bdb4e19
to
f481dc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase against latest master, remove README.md
file from pacakge, and include a copy of the LICENSE
file instead of a symlink, as they break some Haskell tools.
f481dc3
to
bf151b9
Compare
Removed |
@jprupp I made the changes you asked for, is there anything else left to do before this PR can be merged in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Just set yourself as the author and I can merge it.
Changed the names to myself and amended the commit. |
Actually pushed the changes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Fails:
secp256k1-haskell-recovery> test (suite: spec)
Crypto.Secp256k1.Recovery
recovery
recovers public keys [✔]
+++ OK, passed 100 tests.
recovers key from signed message [✔]
+++ OK, passed 100 tests.
does not recover bad public keys [✔]
+++ OK, passed 100 tests.
detects bad recoverable signature [✔]
+++ OK, passed 100 tests.
serializes compact recoverable signature [✔]
+++ OK, passed 100 tests.
shows and reads recoverable signature [✔]
+++ OK, passed 100 tests.
reads recoverable signature from string [✔]
+++ OK, passed 100 tests.
produces the expected signature [✘]
recovers the expected pub key [✔]
+++ OK, passed 1 test.
Failures:
test/Crypto/Secp256k1/RecoverySpec.hs:107:3:
1) Crypto.Secp256k1.Recovery.recovery produces the expected signature
Falsifiable (after 1 test):
produced signature matches
expected: "02559ab98a8908ba4cf0f914eb8b66651405ab69ab7c461dd140e40baa1b5e1d2ef6ac88a13e2226f76a9d8d49bb9cf3061dac1364c0dfe7b69cd165a8d08f0700"
but got: "d0205e402f5c0bc8bbbcf08b3f0912b055fc3998ef0d090c2dec52f98695c4e01cd55228c2370ffe52826b3f2bd82e42fcf94e8943cd402f39644935b2c7c08b00"
To rerun use: --match "/Crypto.Secp256k1.Recovery/recovery/produces the expected signature/"
Randomized with seed 1890685244
Finished in 6.2283 seconds
9 examples, 1 failure
This is a continuation of PR #44, in accordance with the multi-package approach outlined in issue #43.
This has the same functionality as PR #42, but organized differently. Whereas #42 simply adds the recovery functions to the single module; this one has them as a separate package.