Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to use hie-wrapper to launch hie (default: false) #41

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

Tehnix
Copy link
Contributor

@Tehnix Tehnix commented Jan 24, 2018

Following up on haskell/haskell-ide-engine#439.

This adds a hie-wrapper.sh script, which tries to automatically select a hie version that matches the GHC version of the project.

It is enabled by a configuration flag, useHieWrapper, which is set to false by default, until we know if it is stable enough to enable by default. It assumes that the user has built different versions of hie and postfixing them with the GHC their are built for (falling back to plain hie). I've added a Makefile to make this easy in haskell/haskell-ide-engine#447.

I'm amenable to any changes to the script etc, just let me know if there's something you would prefer instead!

Also, I set debug=1 for now, so one can tail -f /tmp/hie-wrapper.log to see if it works. It'll look something like,

Launching HIE for project located at /Users/tehnix/GitHub/Tehnix/STM-Fun
  Using stack GHC version
  The Glorious Glasgow Haskell Compilation System, version 8.0.2
  Project is using GHC 8.0.2
  hie-8.0.2 was found on path
  Starting HIE

@Tehnix
Copy link
Contributor Author

Tehnix commented Jan 24, 2018

Also, if anyone can help port this to batch, that'd be swell :) I've neither Windows to test on, nor any real experience with batch, unfortunately.

@alanz
Copy link
Collaborator

alanz commented Jan 24, 2018

Why are the tests taking so long?

@Tehnix
Copy link
Contributor Author

Tehnix commented Jan 24, 2018

Hmm, it seems to have passed Linux tests, but is waiting on macOS. I heard from others lately that they had been super slow, but not exactly sure why though (the builds haven't even started there) :/

@alanz
Copy link
Collaborator

alanz commented Jan 24, 2018

Ok, I am going to merge, its unlikely to affect things.

@alanz alanz merged commit 50a74e8 into master Jan 24, 2018
@alanz
Copy link
Collaborator

alanz commented Jan 24, 2018

It's live on the market. Thanks.

@Tehnix Tehnix deleted the hie-wrapper branch April 1, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants