Include generic plugin configuration #361
Conversation
jneira
commented
Mar 10, 2021
•
jneira
commented
- Also the new hls logo!
- I've included the global on if the plugin only has one feature, and the features but no global on for the rest, to try reduce them
- Deprecate old hlint config option
- Bump up version to 1.3.0
|
The configuration assumes actual master version, with the specific configuration for type lenses and tactics is present so we should wait to release this until a new hls version or remove that specific configuration meanwhile |
|
Some screenshots
|
|
Thinking it twice, maybe we shouldnt change the logo, as the extension is just haskell and it stills supports ghcide |
|
Ghcide is dead - no one supports it. We provide a HLS extension. While it might happen to work with Ghcide, its totally an HLS extension. Bring on the consistent icon! |
|
Ok, time to remove references from ghcide in the README then? will do in another pr |
|
Yep, I'd remove all trace of Ghcide. If people want to use it, in an unsupported configuration, that's there choice. |
| "haskell.plugin.tactic.config.max_use_ctor_actions": { | ||
| "title": "Max number of constructors", | ||
| "scope": "resource", | ||
| "type": "boolean", | ||
| "default": true, | ||
| "markdownDescription": "Maximum number of `Use constructor <x>` code actions that can appear" | ||
| }, |
There was a problem hiding this comment.
Shouldn't max_use_ctor_actions be an integer?
https://github.com/haskell/haskell-language-server/blob/86d67ffe28871a01f54204b38470bfb49507abc5/plugins/hls-tactics-plugin/src/Wingman/Types.hs#L82
There was a problem hiding this comment.
ugh, you are right, thanks for catching it, will fix it
There was a problem hiding this comment.
And features should be a string, instead of an object
There was a problem hiding this comment.
mm I use that one on purpose, to force vscode editor show a button where you can write arbitrary json (including strings I hope)
There was a problem hiding this comment.
But the server accepts only strings. Why don't we use a textbox?
There was a problem hiding this comment.
tbh i do not get fully that config option, but it seems an advanced one, even obfuscated and it seems to me that it could be an array, no?
but if types say is a String, it is 🙂
There was a problem hiding this comment.
It's a magic string that enables extra features of wingman: haskell/haskell-language-server#1398 (though it can be obtained easily somehow :P)
There was a problem hiding this comment.
ok will change, if the config option gets another type, we can change here at that time
