Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show docs as docs, not as sources #21

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Conversation

AlexeyRaga
Copy link
Contributor

Changes

HIE provides very useful links to documentation and source in a hover popup. Unfortunately, VSCode now opens these links in its tabs as HTML source, not as readable documentation.
The issue was tracked in microsoft/vscode#36452 with the resolution that this behaviour is expected.

This PR fixes the issue by opening haddock docs and sources in a human-readable form:

show-docs

@alanz
Copy link
Collaborator

alanz commented Oct 27, 2017

Thanks

@alanz alanz merged commit 4c189d4 into haskell:master Oct 27, 2017
@YSMull
Copy link

YSMull commented Apr 6, 2018

this feature is not work.
ref:microsoft/vscode#36452
@alanz

@Tehnix
Copy link
Contributor

Tehnix commented Apr 7, 2018

Hmm, it seems this broke after updating the dependency on vscode-languageclient from 3.5 to 4.0.1.

@Tehnix
Copy link
Contributor

Tehnix commented Apr 7, 2018

I've reverted this, since multi-root and everything still seems to be working under 3.5.0. When version 0.0.14 is on the store (building atm), you can get the fix in that version.

@AlexeyRaga
Copy link
Contributor Author

I have fixed the documentation browser in #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants