Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate dependent-sum and dependent-map dependencies #384

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Eliminate dependent-sum and dependent-map dependencies #384

merged 2 commits into from
Dec 27, 2021

Conversation

Bodigrim
Copy link
Contributor

As discussed in #377 (comment)

This removes dependent-map, dependent-sum, constraints-extra and constraints from dependencies and makes lsp buildable with GHC 9.2.

@Bodigrim Bodigrim mentioned this pull request Dec 24, 2021
Merged
jneira
jneira approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not add too much code and it looks good, so it totally worths the drop of deps, many thanks!

@michaelpj
Copy link
Collaborator

Amazing, thanks for doing this!

@michaelpj michaelpj merged commit ad7bc0e into haskell:master Dec 27, 2021
@michaelpj michaelpj mentioned this pull request Dec 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bodigrim @michaelpj @jneira