Use appropriate number types #366
Conversation
|
Many thanks for fixing this. Would need it some work to adapt clients (like hls)? could we do something here to make easier the upgrade? |
|
Yeah, it'll require some changes, but just a scattering of |
| @@ -1,6 +1,7 @@ | |||
| {-# LANGUAGE RankNTypes #-} | |||
| {-# LANGUAGE TemplateHaskell #-} | |||
| {-# LANGUAGE LambdaCase #-} | |||
| {-# LANGUAGE GeneralizedNewtypeDeriving #-} | |||
There was a problem hiding this comment.
Is this needed? There is no other changes in the module
| -- might contain the index of the change that failed. This property is | ||
| -- only available if the client signals a `failureHandling` strategy | ||
| -- in its client capabilities. | ||
| , _failedChange :: Maybe Word32 |
There was a problem hiding this comment.
This is a not related change, maybe it worths to note it as a separate commit or in another way
There was a problem hiding this comment.
Oops thanks, just a small thing I noticed we missed!
lsp/test/JsonSpec.hs
Outdated
| @@ -7,6 +7,9 @@ | |||
| {-# OPTIONS_GHC -fno-warn-orphans #-} | |||
| -- For the use of MarkedString | |||
| {-# OPTIONS_GHC -fno-warn-deprecations #-} | |||
| {-# LANGUAGE DerivingStrategies #-} | |||
| {-# LANGUAGE StandaloneDeriving #-} | |||
| {-# LANGUAGE GeneralizedNewtypeDeriving #-} | |||
There was a problem hiding this comment.
More pragmas with no module changes, maybe they are needed for upstream changes?
This ensures that we use either: - `Int32` - `Word32` - `Float` In particular, this gets us: - Appropriate `Bounded` instances (see the original issue haskell/haskell-language-server#2169). - More picky `aeson` instances for the bounded types. Rather than use newtypes, we just use the existing appropriate Haskell numeric types for bounded integers. Fixes haskell#354.
Just a small missing field.
Since type representations changed.
michaelpj
force-pushed
the
number-newtypes
branch
from
138208f to
493f2cd
Compare
This ensures that we use either:
Int32Word32FloatIn particular, this gets us:
Boundedinstances (see the original issueUse maxBound of uinteger not Int. haskell-language-server#2169).
aesoninstances for the bounded types.Rather than use newtypes, we just use the existing appropriate Haskell
numeric types for bounded integers.
Fixes #354.
NOTE: I also bumped the
lsp-typesmajor version, since this is a type-representation change.