Add support CodeActionOptions (added in LSP spec 3.11.0) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukel97
reviewed
Jul 16, 2019
haskell-lsp-types/src/Language/Haskell/LSP/Types/DataTypesJSON.hs
Outdated
Show resolved
Hide resolved
Co-Authored-By: Luke Lau <[email protected]>
lukel97
approved these changes
Jul 17, 2019
mpickering
reviewed
Oct 15, 2019
| @@ -846,7 +847,7 @@ initializeRequestHandler' onStartup mHandler tvarCtx req@(J.RequestMessage _ ori | |||
| , J._documentHighlightProvider = supported (documentHighlightHandler h) | |||
| , J._documentSymbolProvider = supported (documentSymbolHandler h) | |||
| , J._workspaceSymbolProvider = supported (workspaceSymbolHandler h) | |||
| , J._codeActionProvider = supported (codeActionHandler h) | |||
| , J._codeActionProvider = codeActionProvider o | |||
There was a problem hiding this comment.
This line of the patch is incorrect. It should be implemented like typeDefinitionProvider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. issue #134