Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate typechecking in non-lsp mode #95

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

jneira
Copy link
Member

@jneira jneira commented May 7, 2020

@jneira jneira requested a review from fendor May 7, 2020 07:46
@Philonous
Copy link

The haskell-language-server executable now tries to type check the project, but the ghcide that is installed alongside it still stops after step 4/6.

@jneira
Copy link
Member Author

jneira commented May 7, 2020

@Philonous ideally the ghcide executable should not even be built in this project: we use ghcide as library in a submodule that points to other repo but we cant exclude (easily) the executable from the build. So, in general, fixes in the ghcide executable should belongs to ghcide itself (well actually the fork we are using: https://github.com/mpickering/ghcide/tree/hls)

That said it is a tiny patch and i will open another one upstream

@Philonous
Copy link

@jneira That is fair enough, and I don't really mind, I just wanted to let you know in case you missed it.

@jneira
Copy link
Member Author

jneira commented May 7, 2020

@Philonous yeah, thanks for that i only want to clarify the relation between hls and ghcide, it is a little bit blurry, even for me! 😄

@jneira jneira merged commit bf6a85d into haskell:master May 7, 2020
@jneira
Copy link
Member Author

jneira commented May 7, 2020

That said it is a tiny patch and i will open another one upstream

It turned out that it is already fixed in https://github.com/mpickering/ghcide/tree/hls so all done here

@jneira jneira deleted the typecheck-on branch May 7, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

haskell-language-server 0.1 stops before checking files
3 participants