-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get building with ghc-8.10 #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Do you need to update the stack*.yaml files as well, so that everything is using the same versions?
@fendor I think we might need to update ghcide first, I'm not sure if we can use allow-newer on a per package basis in a stack.yaml file |
Just realised that there's no stackage snapshot for ghc 8.10 yet, so it doesn't matter. Updated the stack files |
CI needs still updates right? |
Like update the cabal circleCI job? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merge when CI is "greenish", e.g. no build failure
Looks like there's no docker image for 8.10 yet either :( |
This reverts commit 221e006. There's no docker image available yet
@alanz @fendor I think we can create a new release of haskell-lsp with updated bounds before merging this, to avoid extra submodules?
Also the mpickering hie-bios fork should have the changes from the fendor fork now