Ci fixes #783
Merged
Ci fixes #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, I hope we can recover reasonable ci build times with those nice changes |
jneira
approved these changes
Jan 1, 2021
pepeiborra
force-pushed
the
ci-fixes
branch
4 times, most recently
from
a273c71 to
04bb1bf
Compare
jneira
reviewed
Jan 1, 2021
| @@ -30,14 +30,16 @@ jobs: | |||
| ghc-lib: true | |||
|
|
|||
| steps: | |||
| # Cancel queued workflows from earlier commits in this branch | |||
| - uses: fkirc/skip-duplicate-actions@master | |||
|
What about restrict tests to last minor versions, like we did in ghcide? We could include macos and still save jobs |
|
Where those compile error comes from? weird thing that changing ci settings could trigger them |
It occasionally becomes much slower than the others and times out after 6h https://github.com/haskell/haskell-language-server/runs/1626173853?check_suite_focus=true
actions/setup-haskell has been archived, haskell/actions/setup is the replacement
We are getting very few cache hits because we have too many caches and are running over the 5GB per repository limit. Each node in the matrix weighs around 350MB, so we can have up to 15 nodes. The current matrix (after dropping macOS but before adding 8.10.3) has 12 nodes. The `**/*.cabal` hash is wrong, since it also captures cabal files in tests The `**/cabal.project` is wrong for the same reason, but it can be easily fixed.
We simply need to check that the Nix derivation works
Created haskell#784 to restore it
|
I don't know if the auto cancel action will work - if it doesn't we'll need to keep an eye on https://github.community/t/github-actions-cancel-redundant-builds-not-solved/16025 |
|
@pepeiborra i've triggered two consecutive builds and the cancel action has failed with otoh i've observed the build times of cabal are significative better in the second build, at least for ubuntu: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages