Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ghc-8.10.3 support after merging ghcide repo #721

Merged
merged 12 commits into from
Jan 2, 2021
Merged

Add ghc-8.10.3 support after merging ghcide repo #721

merged 12 commits into from
Jan 2, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Dec 29, 2020

  • Let's see how is going

@jneira jneira force-pushed the mergepocalypse-8.10.3 branch from 87726bc to 1aa1ce1 Compare December 30, 2020 14:36
@jneira
Copy link
Member Author

jneira commented Dec 31, 2020

ci behaves like the previous pr so i would release this one

@jneira jneira force-pushed the mergepocalypse-8.10.3 branch from 1eaf924 to 975808c Compare December 31, 2020 16:31
@alanz
Copy link
Collaborator

alanz commented Dec 31, 2020

ci behaves like the previous pr so i would release this one

Sounds good to me.

@pepeiborra
Copy link
Collaborator

I'm very reluctant to add more GitHub Actions, the CI is already completely overwhelmed. Is there anything we can drop in exchange?

Ailrun
Ailrun approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
BTW, I also agree with @pepeiborra in that CI is already overwhelmed. It might be better to find some optimizable parts in CI.

@alanz
Copy link
Collaborator

alanz commented Dec 31, 2020

FYI, there was a chat on IRC with @bgamari about hosting CI on the GHC infrastructure. Something we should explore.

@jneira
Copy link
Member Author

jneira commented Jan 1, 2021

I'm very reluctant to add more GitHub Actions, the CI is already completely overwhelmed. Is there anything we can drop in exchange?

only tests last minor version in gh f.e.

@bgamari
Copy link

bgamari commented Jan 1, 2021

The CI issue is being discussed in #780 .

@jneira jneira force-pushed the mergepocalypse-8.10.3 branch from 975808c to b4577a2 Compare January 1, 2021 16:33
@jneira jneira force-pushed the mergepocalypse-8.10.3 branch from b4577a2 to f3bf627 Compare January 1, 2021 20:52
@jneira
Copy link
Member Author

jneira commented Jan 2, 2021

ci is green! we will use master with this for the next release if nobody disagree

@jneira jneira merged commit 4d33fd1 into haskell:master Jan 2, 2021
@jneira jneira mentioned this pull request Jan 2, 2021
Closed
@jneira jneira deleted the mergepocalypse-8.10.3 branch January 3, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@alanz alanz Awaiting requested review from alanz

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jneira @alanz @pepeiborra @bgamari @Ailrun