Move eval plugin to hls-eval-plugin

[tittoassini]

Eval plugin moved to its own subpackage (as agreed with @pepeiborra).

[Ailrun]

LGTM

[pepeiborra]

The tests should be moved to the new package as well

[tittoassini]

The tests should be moved to the new package as well

Just the testdata? Or also the test/functional/Eval.hs ?

Should plugins have totally separate test suites or should they still be integrated into the main func-test?

[pepeiborra]

Tests and test data should all be moved to the plugin, so that eventually the plugin can be uploaded to Hackage (and even extracted to its own GitHub repository when/if that becomes desirable)

[Ailrun]

I think what @pepeiborra meant is not only moving code files into inner directory but also moving (and adding) test-suite to hls-eval-plugin.cabal like tactic plugin.

[tittoassini]

The integration tests of all plugins, including tactic, are run from the main package as func-test. Unless we change completely the testing logic I don't see how it could be otherwise, or what we would gain from doing it differently (at least till plugins can be loaded dynamically and therefore be developed completely independently from the main server). It might make sense to move them physically in their own directory, as I have done, but they still have to be called from func-test. In addition, the tactic plugin has a few unit tests that are run locally. The eval plugin has also a bunch of unit tests. If you look at the source there are plenty of tests in the comments, run using 'eval' itself. Currently, they are run manually but I am planning to extract and run them automatically as a local unit test, but this is for a future PR. Il giorno dom 27 dic 2020 alle ore 04:01 Junyoung Clare Jang < [email protected]> ha scritto:

…

***@***.**** commented on this pull request. ------------------------------ In haskell-language-server.cabal <#700 (comment)> : > @@ -373,7 +373,7 @@ test-suite func-test , tasty-golden , tasty-rerun - hs-source-dirs: test/functional plugins/tactics/src + hs-source-dirs: test/functional plugins/tactics/src plugins/hls-eval-plugin/test I think what @pepeiborra <https://github.com/pepeiborra> meant is not only moving code files into inner directory but also moving (and adding) test-suite to hls-eval-plugin.cabal like tactic plugin. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#700 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFRQLP3JYPH77U24VOU3LSW2PPDANCNFSM4VJNSJTQ> .

-- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/

[pepeiborra]

Ouch, I think you are right, it's not currently possible to run functional tests without incurring a dependency on haskell-language-server, which would create a cycle in the Cabal graph and complicate things massively.

[jneira]

Yep, we have an issue about how structure tests for plugins: #576

[jneira]

@pepeiborra do you think we should merge this before the mergepocalypse?
@tittoassini in any case it would need a rebase for the pesky stack.yaml's