Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for diagnostics in tactics tests #525

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Wait for diagnostics in tactics tests #525

merged 1 commit into from
Oct 21, 2020

Conversation

isovector
Copy link
Collaborator

This appears to be the fix for the flaky tactics fixes, and should unblock #521 and #166. Thanks to @jneira for all of his hard work in tracking it down.

@isovector isovector requested a review from jneira October 21, 2020 08:14
@isovector
Copy link
Collaborator Author

I'm off to bed, but feel free to merge this if you'd like!

jneira
jneira approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@jneira jneira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you too, glad to help unblock ugly issues to move the great tactic public forward

@jneira
Copy link
Member

jneira commented Oct 21, 2020 •
edited
Loading

Jumm circleci builds are not triggered, i guess the author needs to have an account 🤦
They suddenly show up so nvm

@jneira jneira merged commit f766476 into haskell:master Oct 21, 2020
@isovector isovector deleted the tactics-diagnostics branch July 19, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isovector @jneira