CI change, only run bench on performance label #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulomoon
added
the
performance
soulomoon
commented
May 29, 2024
| @@ -17,6 +17,7 @@ on: | |||
| jobs: | |||
| pre_job: | |||
| runs-on: ubuntu-latest | |||
| if: contains(github.event.pull_request.labels.*.name, 'performance') | |||
There was a problem hiding this comment.
I am not quite sure if this is enough ?
soulomoon
added
CI
|
CI looks like it skipped the benchmark job. Do we want to run the benchmarks as nightly jobs perhaps? Ideally, there would be an easy way to access them later. |
|
CI already skipped bench on some occasions. And we almost never look at them unless we touch performance related code. I think for now, if we touch performance related, manually adding the performance label should be enough. But we can still add the nightly runs, if someone wants it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the
performancelabel