Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code in ghcide and hls-graph for priority #4151

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Mar 25, 2024

In the current status of hls-graph, action priority is handled by rts scheduler.
We do not have a scheduler in hls-graph.

@soulomoon soulomoon changed the title Remove dead code in ghcide Remove dead code in ghcide and hls-graph Mar 25, 2024
@soulomoon soulomoon changed the title Remove dead code in ghcide and hls-graph Remove dead code in ghcide and hls-graph for priority Mar 25, 2024
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. What is there would not be hard to put back again if we needed it.

@soulomoon soulomoon marked this pull request as ready for review March 25, 2024 23:22
@soulomoon soulomoon requested a review from pepeiborra as a code owner March 25, 2024 23:22
@soulomoon soulomoon merged commit 3668683 into haskell:master Mar 25, 2024
39 checks passed
@soulomoon
Copy link
Collaborator Author

soulomoon commented Mar 25, 2024

Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants