Eval plugin: proper multilined results handling and command-name abbreviations #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request consists of two changes to Eval plugin:
Bugfix: a proper treatment of multilined results.
Previously, GHCi-like commands in Eval plugin doesn't treat multilined results properly.
For example, with the current Eval plugin we get:
Apparlently, the last two lines must be prefixed with
--
.This pull request addresses this issue and now it seems that the plugin returns the same result as GHCi:
It tries to use
Outputable.SDoc
to generate the same alignment as the GHCi.New feature: abbreviation for GHCi commands.
Eval plugin now lookups GHCi-like commands first by exact match, then fallbacks to the first element in the dictionary with the given prefix.
Since there are just three commands currently, I just used lists to implement command dictionary; perhaps we should use some kind of trie in a future?