Fix -Wall and -Wunused-packages in hlint plugin #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
approved these changes
Jan 26, 2024
jhrcek
force-pushed
the
jhrcek/unused-packages-hlint
branch
from
c2ac0ed to
a92f44a
Compare
jhrcek
force-pushed
the
jhrcek/unused-packages-hlint
branch
from
a92f44a to
78303ea
Compare
jhrcek
commented
Feb 1, 2024
| @@ -142,7 +142,7 @@ flag cabal | |||
|
|
|||
| common cabal | |||
| if flag(cabal) | |||
| build-depends: haskell-language-server:hls-cabal-plugin | |||
| build-depends: haskell-language-server:hls-cabal-plugin | |||
There was a problem hiding this comment.
Sorry for the noise, but I have editor setup to remove trailing whitespace. I don't think it hurts to clean these up as part of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.