refactor plugin: add reproducer and fix for #3795 #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jhrcek
commented
Jan 24, 2024
•
jhrcek
commented
- adding reproducer for Code action to define undefined variables includes suggestions in type signature #3795
- fixing the bug
- fixing bunch of warnings in refactor plugin tests
jhrcek
commented
Jan 25, 2024
| @@ -102,7 +102,7 @@ test-suite tests | |||
| hs-source-dirs: test | |||
| main-is: Main.hs | |||
| other-modules: Test.AddArgument | |||
| ghc-options: -O0 -threaded -rtsopts -with-rtsopts=-N -Wunused-imports | |||
| ghc-options: -O0 -threaded -rtsopts -with-rtsopts=-N -Wno-name-shadowing | |||
There was a problem hiding this comment.
-Wunused-imports is already part of -Wall imported via import: warnings.
On the other hand these tests rely on shadowing a lot, so disabling this warning.
jhrcek
changed the title
jhrcek
commented
Jan 25, 2024
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/Plugins/Diagnostic.hs
Show resolved
Hide resolved
fendor
requested changes
Jan 26, 2024
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/Plugins/Diagnostic.hs
Show resolved
Hide resolved
fendor
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.