Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most -Wall in ghcide #3984

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Jan 19, 2024

No description provided.

@jhrcek jhrcek requested a review from pepeiborra as a code owner January 19, 2024 06:48
@jhrcek jhrcek marked this pull request as draft January 19, 2024 06:53
@jhrcek jhrcek force-pushed the jhrcek/wall-ghcide-part-1 branch from e56e2d1 to 8df8e35 Compare January 19, 2024 17:51
@jhrcek jhrcek marked this pull request as ready for review January 20, 2024 07:24
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jan 20, 2024
@mergify mergify bot merged commit 0a02832 into haskell:master Jan 21, 2024
42 checks passed
josephsumabat pushed a commit to josephsumabat/haskell-language-server that referenced this pull request Jan 22, 2024
* Fix most -Wall in ghcide

* Fix ghc 9.2.8

* No spaces after CPP #

---------

Co-authored-by: Michael Peyton Jones <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@jhrcek jhrcek deleted the jhrcek/wall-ghcide-part-1 branch January 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants