Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties API: Remove unsafe coerce in favor of type class based method in #3947

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Properties API: Remove unsafe coerce in favor of type class based method in #3947

merged 5 commits into from
Jan 13, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Jan 13, 2024 •
edited
Loading

After removal of unsafe coerce the api would not be affected

@soulomoon soulomoon linked an issue Jan 13, 2024 that may be closed by this pull request
Extend the Properties api to better support nested configuration #3944
Closed
@soulomoon
Copy link
Collaborator Author

soulomoon commented Jan 13, 2024 •
edited
Loading

The redundant-constraints suppression can also be removed.

@soulomoon soulomoon mentioned this pull request Jan 13, 2024
Closed
@soulomoon soulomoon force-pushed the 3944-extend-the-properties-api-to-better-support-nested-configuration branch from 51c2340 to 72d625a Compare January 13, 2024 13:35
@soulomoon soulomoon changed the title Remove unsafe coerce in favor of type class based method in Plugin API Remove unsafe coerce in favor of type class based method in properties of Plugin API Jan 13, 2024
@soulomoon soulomoon changed the title Remove unsafe coerce in favor of type class based method in properties of Plugin API Properties API: Remove unsafe coerce in favor of type class based method in Jan 13, 2024
@soulomoon soulomoon marked this pull request as ready for review January 13, 2024 15:18
michaelpj
michaelpj approved these changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible, although I haven't worked it all through in my head. Definitely worth considering if this stuff can be simplified.

Note that I think it would be pretty reasonable for us to actually depend on singletons - the base library is pretty small, and it has a lot of vocabulary for this kind of thing.

@soulomoon
Copy link
Collaborator Author

Looks plausible, although I haven't worked it all through in my head. Definitely worth considering if this stuff can be simplified.

Note that I think it would be pretty reasonable for us to actually depend on singletons - the base library is pretty small, and it has a lot of vocabulary for this kind of thing.

Yes, it is for the singleton pattern. And also we can take a look at Oleg Kiselyov's HList for for type level list and record. But it it would be complete rewrite of current implementations, I think we can considered them in the future.

@soulomoon soulomoon merged commit 10b5f3b into master Jan 13, 2024
40 checks passed
@chenrui333 chenrui333 mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@fendor fendor Awaiting requested review from fendor fendor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend the Properties api to better support nested configuration
2 participants
@soulomoon @michaelpj