Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to minor API change for 9.6.4 compatibility #3929

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Jan 5, 2024

The CPP will need to be adjusted again for 9.8.2 as the patch
is likely to be backported there as well.

The CPP will need to be adjusted again for 9.8.2 as the patch
is likely to be backported there as well.
@wz1000 wz1000 requested a review from pepeiborra as a code owner January 5, 2024 10:45
@wz1000 wz1000 added the merge me Label to trigger pull request merge label Jan 8, 2024
@mergify mergify bot merged commit f4df1aa into master Jan 8, 2024
42 checks passed
@wz1000 wz1000 mentioned this pull request Jan 11, 2024
@benz0li
Copy link

benz0li commented Feb 25, 2024

Please adjust again for GHC 9.8.2 as building of HLS 2.6.0.0 currently fails:


My environment

Which OS do you use? Alpine Linux 3.19.0

Which version of GHC do you use and how did you install it? 9.8.2
👉 Docker image glcr.b-data.ch/ghc/ghc-musl:9.8.2 (https://github.com/benz0li/ghc-musl)

Steps to reproduce

On a host with docker installed

docker run --rm -ti glcr.b-data.ch/ghc/ghc-musl:9.8.2 bash

Inside the container

export HLS_VERSION=2.6.0.0 \
  && apk add --no-cache patchelf findutils \
  && cd /tmp \
  && curl -sSL "https://github.com/haskell/haskell-language-server/archive/refs/tags/$HLS_VERSION.tar.gz" \
    -o "haskell-language-server-$HLS_VERSION.tar.gz" \
  && tar -xzf "haskell-language-server-$HLS_VERSION.tar.gz" \
  && cd "haskell-language-server-$HLS_VERSION" \
  && . .github/scripts/env.sh \
  && . .github/scripts/common.sh \
  && sed -i.bak -e '/DELETE MARKER FOR CI/,/END DELETE/d' cabal.project \
  && GHCS="$GHC_VERSION" \
  && export GHCS \
  && ARTIFACT="$(uname -m)-linux-alpine" \
  && export ARTIFACT \
  && cabal update \
  && emake hls-ghc \
  && emake bindist \
  && strip "out/bindist/$ARTIFACT/haskell-language-server-$HLS_VERSION/lib/$GHC_VERSION"/*.so \
  && emake bindist-tar

Logfile

logfile.txt

FYI @michaelpj

benz0li added a commit to benz0li/ghc-musl that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants