Demote home unit closure errors to warnings. #3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
force-pushed
the
wip/multi-warn
branch
2 times, most recently
from
341b3c7 to
ad802da
Compare
Users can't really do anything to fix them until cabal 3.12 is released. Perhaps they could previously get by despite the unsoundess before we started throwing these errors. So demote them to warnings to allow HLS to continue to "function" despite them.
wz1000
force-pushed
the
wip/multi-warn
branch
from
ad802da to
2a0d4f7
Compare
fendor
approved these changes
Dec 9, 2023
it's quite small if you ignore whitespace changes. |
|
Yeah, essentially merely the case branch has been removed and you report potential closure property violations as warnings. So LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can't really do anything to fix them until cabal 3.12 is released.
Perhaps they could previously get by despite the unsoundness before we started
throwing these errors.
So demote them to warnings to allow HLS to continue to "function" despite them.