Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load default operator fixities in Fourmolu plugin non-CLI mode #3855

Merged
merged 8 commits into from
Oct 31, 2023

Conversation

georgefst
Copy link
Collaborator

Fixes #3788. I'm not particularly familiar with this part of the API, but this seems to do the job. It's similar to what the Ormolu plugin already does.

@georgefst georgefst force-pushed the fourmolu-default-fixities branch from 0e34368 to abbd362 Compare October 29, 2023 21:54
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we have a test that shows the changed behaviour?

@georgefst georgefst force-pushed the fourmolu-default-fixities branch from a182b64 to 1c55cb4 Compare October 31, 2023 00:12
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@fendor fendor added the status: needs review This PR is ready for review label Oct 31, 2023
@georgefst georgefst enabled auto-merge October 31, 2023 11:13
@georgefst georgefst merged commit f2c6b02 into master Oct 31, 2023
39 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fourmolu plugin formats code differently compared to separate installation of fourmolu
2 participants