Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cabal.project #3836

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Simplify cabal.project #3836

merged 1 commit into from
Oct 12, 2023

Conversation

michaelpj
Copy link
Collaborator

  • entropy has had bounds revised in
  • basement/hw-prim bounds empirically unnecessariy
  • hyphenation was for wingman
  • bound hlint to a version that uses ghc-lib by default
  • stylish-haskell has never had a ghc-lib flag
  • none of the versions of fourmolu that we use have a fixity-th flag
  • remove some other things that lack justification speculatively
  • make shake-bench buildable on later GHCs

@michaelpj michaelpj force-pushed the mpj/cabal-project-tidy branch 2 times, most recently from a42d3a0 to 59dbf39 Compare October 11, 2023 10:35
- entropy has had bounds revised in
- basement/hw-prim bounds empirically unnecessariy
- hyphenation was for wingman
- bound hlint to a version that uses ghc-lib by default
- stylish-haskell has never had a ghc-lib flag
- none of the versions of fourmolu that we use have a fixity-th flag
- remove some other things that lack justification speculatively
@michaelpj michaelpj marked this pull request as ready for review October 12, 2023 10:10
@michaelpj michaelpj requested a review from eddiemundo as a code owner October 12, 2023 10:10
@michaelpj michaelpj force-pushed the mpj/cabal-project-tidy branch from 9d80692 to 7bef5dd Compare October 12, 2023 10:10
@michaelpj michaelpj requested a review from pepeiborra as a code owner October 12, 2023 10:10
@michaelpj michaelpj requested a review from fendor October 12, 2023 10:11
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one question

Comment on lines -46 to -47
package mfsolve
tests: False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not needed anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how it ever was - unless we had a srp for mfsolve at some point.

@michaelpj michaelpj merged commit c0f7d4c into master Oct 12, 2023
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants