Cleanup func-test suite #3828
Merged
Cleanup func-test suite #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
enhance/overhaul-func-test
branch
from
747ace8 to
7b5b7ac
Compare
fendor
commented
Oct 5, 2023
Comment on lines
+6
to
+7
| /hls-test-utils @fendor | ||
| /test @fendor |
There was a problem hiding this comment.
I noticed that hls-test-utils has no codeowner, I am volunteering to take over the ownership.
Additionally, added myself as codeowner for func-test. Mostly, to make sure my somewhat arbitrary guidance in test/README.md cannot be further violated without me noticing.
fendor
force-pushed
the
enhance/overhaul-func-test
branch
from
4dd9981 to
5ba5c7a
Compare
michaelpj
approved these changes
Oct 6, 2023
|
Yeah, that's true. |
fendor
force-pushed
the
enhance/overhaul-func-test
branch
2 times, most recently
from
6723923 to
3bd5190
Compare
|
I think, the only tests that should really be in The rest could live somewhere else... |
fendor
force-pushed
the
enhance/overhaul-func-test
branch
from
3bd5190 to
7ae93da
Compare
|
For some reason, the tests get slower if I move them to ghcide. Until I got to the bottom of this, I won't move the tests, and leave them here. |
This test-suite is vastly legacy from Haskell IDE Engine. It was originally written before we had a plugin-based architecture where each plugin tests its feature in isolation. Over time, this test-suite bitrotted, where a lot of testcases were either redundant or out-of-date and consequentially disabled. We clean up the test-suite, delete old tests and remove unused testdata.
Provides guidance when to add a test to `func-test` and some historical context.
fendor
force-pushed
the
enhance/overhaul-func-test
branch
from
7ae93da to
cb2b380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test-suite is vastly legacy from Haskell IDE Engine. It was originally written before we had a plugin-based architecture, where each plugin tests its feature in isolation.
Over time, this test-suite bitrotted, where a lot of testcases were either redundant or out-of-date and consequentially disabled.
Further, make sure we only have tests here that need to be integration tests.
We clean up the test-suite, delete old tests and remove unused testdata.
Before we merge:
func-test.closes #3365