Reduce Nix support #3804
Merged
Reduce Nix support #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cydparser
approved these changes
Sep 13, 2023
.github/workflows/nix.yml
Outdated
|
|
||
| # Enter the development shell and run `cabal build` | ||
| develop: | ||
| if: needs.pre_job.outputs.should_skip_develop != 'true' | ||
| needs: pre_job | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| HAS_TOKEN: ${{ secrets.HLS_CACHIX_AUTH_TOKEN != '' }} |
There was a problem hiding this comment.
HAS_TOKEN appears unused.
This removes the support for: - Dev shells with pre-built packages - Building binaries These have been almost continually broken, and nobody is really maintaining them. Better to just do the simple thing we can do reliably, which is to provide dev shells. Closes #3800
michaelpj
force-pushed
the
mpj/reduce-nix
branch
from
950cd23 to
de85bf4
Compare
michaelpj
requested review from
berberman,
guibou,
Anton-Latukha and
Ailrun
as code owners
guibou
approved these changes
Nov 14, 2023
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the support for:
These have been almost continually broken, and nobody is really maintaining them. Better to just do the simple thing we can do reliably, which is to provide dev shells.
Closes #3800